Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/configNetwork.py
Line 627: get('bonding') in bondings)
Line 628: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION,
Line 629: 'connectivity check failed')
Line 630:
Line 631: hooks.after_network_setup({'networks': dict(networks),
Toni, Assaf, It's not clear to me why do we need to pass RunningConfig to the
hooks? The hook could deduce it by introspecting the host config.
Line 632: 'bondings': dict(bondings),
Line 633: 'options': dict(options)})
Line 634:
Line 635:
--
To view, visit http://gerrit.ovirt.org/20330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
