Yaniv Bronhaim has posted comments on this change.
Change subject: Add --force option to upgrades
......................................................................
Patch Set 1:
(3 comments)
....................................................
File lib/vdsm/tool/upgrade.py
Line 117: self._detachUpgradeLog()
Line 118:
Line 119:
Line 120: def _parse_args():
Line 121: parser = argparse.ArgumentParser('vdsm-tool')
it will print:
usage: vdsm-tool [--force]
you should add the function's name
Line 122: parser.add_argument(
Line 123: '--force',
Line 124: dest='force',
Line 125: default=False,
Line 125: default=False,
Line 126: action='store_true',
Line 127: help='Run the upgrade again, even if it was ran before',
Line 128: )
Line 129: return parser.parse_args(sys.argv[2:])
sys.argv? iirc you don't call it only by vdsm-tool call.. shouldn't it be the
args sent to the command? pass it..
Line 130:
Line 131:
Line 132: def upgrade(upgradeName):
Line 133: """
....................................................
File lib/vdsm/tool/upgrade_300_networks.py
Line 64: """
Line 65: networks = netinfo.networks()
Line 66: bridges = netinfo.bridges()
Line 67:
Line 68: if isNeeded(networks, bridges):
should be "and not --force"?
--
To view, visit http://gerrit.ovirt.org/22750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6b84bdd14b9cd3921cea187b2654be22989334
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
