Assaf Muller has posted comments on this change.
Change subject: Fixing call to setLinkAndNetwork after hook
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/vm.py
Line 3237: custom)
Line 3238: self._dom.updateDeviceFlags(vnicStrXML,
Line 3239:
libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 3240: dev._deviceXML = vnicStrXML
Line 3241: self.log.debug("Nic has been updated:\n %s" %
vnicStrXML)
Well, if you're gonna use named parameters I guess it would make sense to use
them all the way... The 2nd parameter is named as well.
Line 3242: hooks.after_update_device(vnicStrXML, self.conf,
params=custom)
Line 3243: except Exception as e:
Line 3244: self.log.debug('Request failed: %s', vnicStrXML,
exc_info=True)
Line 3245: hooks.after_update_device_fail(vnicStrXML, self.conf,
--
To view, visit http://gerrit.ovirt.org/22884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
