Francesco Romani has posted comments on this change.
Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor
and product id
......................................................................
Patch Set 11:
(2 comments)
....................................................
File vdsm_hooks/hostusb/after_vm_destroy.py
Line 67: usefilter = False
Line 68:
Line 69: for usb in os.environ['hostusb'].split('&'):
Line 70:
Line 71: if usb.find('@') != -1:
I have a preference for
'@' in usb
Line 72: usbvp, filter = usb.split('@')
Line 73: vendorid, productid = usbvp.split(':')
Line 74: fbusid, fphydevid = filter.split(':')
Line 75: usefilter = True
....................................................
File vdsm_hooks/hostusb/before_vm_start.py
Line 121: devices = domxml.getElementsByTagName('devices')[0]
Line 122:
Line 123: for usb in os.environ['hostusb'].split('&'):
Line 124:
Line 125: if usb.find('@') != -1:
same here imo better '@' in usb
Line 126: usbvp, filter = usb.split('@')
Line 127: vendorid, productid = usbvp.split(':')
Line 128: fbusid, fphydevid = filter.split(':')
Line 129: usefilter = True
--
To view, visit http://gerrit.ovirt.org/14237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I831d047e5a2284dcc2e4db7608a9831e64f9c8dc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Guglielmi <david.guglie...@gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: David Guglielmi <david.guglie...@gmail.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
