Hello Vinzenz Feenstra, Assaf Muller, Francesco Romani, I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22950 to review the following change. Change subject: update NIC: having no custom properies is valid ...................................................................... update NIC: having no custom properies is valid Older Engines, that preceded per-vNIC custom properties (Vdsm commit 38b1f8fb) do not send the "custom" element at all. This has to be interpreted exactly as an empty custom element. Bug-Url: https://bugzilla.redhat.com/1047646 Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Signed-off-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/22922 Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Vinzenz Feenstra <vfeen...@redhat.com> Reviewed-by: Assaf Muller <amul...@redhat.com> --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/22950/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 8f48bca..6b2de55 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -3161,7 +3161,7 @@ if network == '': network = DUMMY_BRIDGE linkValue = 'down' - custom = params.get('custom') + custom = params.get('custom', {}) netsToMirror = params.get('portMirroring', netConf.get('portMirroring', [])) -- To view, visit http://gerrit.ovirt.org/22950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If510f012039304ad16000d46d9d72a3e035539f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches