Dan Kenigsberg has submitted this change and it was merged.

Change subject: BindingXMLRPC cleanup: Inline getServerInfo
......................................................................


BindingXMLRPC cleanup: Inline getServerInfo

Inlining getServerInfo because:
1) It's used exactly once
2) I'd like to avoid people using it at all. It only works
   if there's exactly one client, and only for one command
   at a time. It works for the purposes it's used, but if
   (code) users expect it to work for all cases they'd be
   in for a surprise

Change-Id: I9f19630f995c2fe9fb3e3c11e4027f22f98722ba
Signed-off-by: Assaf Muller <amul...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22835
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 4 insertions(+), 10 deletions(-)

Approvals:
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22835
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f19630f995c2fe9fb3e3c11e4027f22f98722ba
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to