Assaf Muller has posted comments on this change. Change subject: hooks: Security groups support for OVS ......................................................................
Patch Set 4: (1 comment) .................................................... File vdsm_hooks/openstacknet/Makefile.am Line 38: install-data-hook: Line 39: chmod 440 $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_hook_openstacknet Line 40: Line 41: install-data-local: install-data-consts install-data-sudoers Line 42: $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_device_create There's no migrate fail hook point at this time. We could implement a new after_migrate_fail_destination hook point, but I don't think it should block this patch. I think it's still definitely better to support migrations and have messy destinations on failed migrations, than not support migrations at all. Line 43: $(INSTALL_SCRIPT) $(srcdir)/after_device_create.py \ Line 44: $(DESTDIR)$(vdsmhooksdir)/after_device_create/50_openstacknet Line 45: $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_device_destroy Line 46: $(INSTALL_SCRIPT) $(srcdir)/after_device_destroy.py \ -- To view, visit http://gerrit.ovirt.org/22585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77e219cce9c572ebef6a8584847f517abbda224d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
