Francesco Romani has posted comments on this change. Change subject: tests: use assertIn when applicable ......................................................................
Patch Set 1: Code-Review-1 I fully agree with the intent of the patch and I like it. Unfortunately, assertIn (and a lot of more specific and useful methods) is available only in python 2.7 http://docs.python.org/2/library/unittest.html#assert-methods This will require unittest2 as backport (!), or as external dependency or not to go and be python 2.6 friendly -- To view, visit http://gerrit.ovirt.org/23038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf30dae017ba9e028b0adf00e1edab04c3b27c0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
