Assaf Muller has posted comments on this change.

Change subject: Gluster API verbs will now be callable again
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 79:         self.server.server_close()
Line 80:         self._thread.join()
Line 81:         return {'status': doneCode}
Line 82: 
Line 83:     @staticmethod
Why in this patch though?
I think this is the correct solution to the regression (+ the ovirt-3.3 patch), 
and moving this function to API should be done in a separate patch, no?
Line 84:     def updateTimestamp():
Line 85:         # FIXME: The setup+editNetwork API uses this log file to
Line 86:         # determine if this host is still accessible.  We use a
Line 87:         # file (rather than an event) because setup+editNetwork is


-- 
To view, visit http://gerrit.ovirt.org/23044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibab01ef654e7ac469ea0a2594c4744918ae24819
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to