Francesco Romani has posted comments on this change. Change subject: clientIF: replace type() with isinstance() ......................................................................
Patch Set 1: Nir, thanks for the detailed review. I definitely see your point. This tiny patch, altough armed only with good intentions, heads in the wrong direction. I'll put more effort in the points you highlighted. -- To view, visit http://gerrit.ovirt.org/23056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53afef3476a2aedbc5dac830a99f6ee9c093688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
