Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) ......................................................................
Patch Set 24: Code-Review-1 (1 comment) one last documentation nit, and we're good to go. .................................................... File vdsm_api/vdsmapi-schema.json Line 2854: '*cpuType': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 2855: 'display': 'VmDisplayType', 'displayIp': 'str', Line 2856: 'displayPort': 'int', 'displaySecurePort': 'int', Line 2857: '*emulatedMachine': 'str', '*keyboardLayout': 'str', Line 2858: 'kvmEnable': 'bool', '*maxVCpus': 'str', 'memSize': 'uint', it should be a 'uint' (even though it is encoded as a string due to xmlrpc limitations - much like smp. Line 2859: 'memGuaranteedSize': 'uint', 'nicModel': 'str', 'nice': 'int', Line 2860: '*pauseCode': 'str', 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 2861: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus', Line 2862: 'timeOffset': 'uint', 'transparentHugePages': 'bool', -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
