Yaniv Bronhaim has submitted this change and it was merged.

Change subject: configNetwork: Fix bridgeless broken network deletion
......................................................................


configNetwork: Fix bridgeless broken network deletion

When trying to delete a broken bridgeless vdsm network, if the iface
referenced by the network definition was missing, delNetwork would
not get any device on its call for vlan, nic and bonds, but
objectivize would be called nonetheless, failing with a:

ERR_BAD_PARAMS: 'Network defined without devices.'

The fix consists on just removing the network from libvirt when the
backing device is missing.

Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503
Bug-Url: https://bugzilla.redhat.com/1044024
Signed-off-by: Antoni S. Puimedon <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/22354
Reviewed-by: Dan Kenigsberg <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/22436
Reviewed-by: Yaniv Bronhaim <[email protected]>
Tested-by: Yaniv Bronhaim <[email protected]>
---
M tests/functional/networkTests.py
M tests/functional/utils.py
M vdsm/configNetwork.py
3 files changed, 34 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22436
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to