Nir Soffer has posted comments on this change. Change subject: Moving import of zombierepear ......................................................................
Patch Set 1: This is not about style but about having easy to understand dependencies. From the commit message I understand that utils.py is imported during make rpm, so this render all the modules imported there as build dependencies. So the correct solution would be to edit vdsm.spec.in and add the required packages in the build dependencies section. -- To view, visit http://gerrit.ovirt.org/23180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906b4f4212dd455cdf3ffc2b2409f2e57c9845e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
