Assaf Muller has posted comments on this change. Change subject: Extend setupNetworks API to accept defaultRoute ......................................................................
Patch Set 2: (2 comments) .................................................... File lib/vdsm/tool/unified_persistence.py Line 97: if netParams['gateway'] != '': Line 98: networks[network]['gateway'] = netParams['gateway'] Line 99: Line 100: networks[network]['defaultRoute'] = \ Line 101: str(network in MANAGEMENT_NETWORKS) str conversion is needed because for whatever reason when serializing to json, True is converted to true. true cannot be sent to setupNetworks (True, 'true', 'True' are all good. true is not). Line 102: Line 103: # What if the 'physical device' is actually a VLAN? Line 104: if physicalDevice in netinfo.vlans: Line 105: vlanDevice = physicalDevice .................................................... File vdsm/configNetwork.py Line 49: Line 50: def objectivizeNetwork(bridge=None, vlan=None, bonding=None, Line 51: bondingOptions=None, nics=None, mtu=None, ipaddr=None, Line 52: netmask=None, gateway=None, bootproto=None, Line 53: ipv6addr=None, ipv6gateway=None, ipv6autoconf=None, If setupNetworks gets an explicit defaultRoute, then with patch set 1 defaultRoute is sent as a keyword argument and in **opts as well. Line 54: dhcpv6=None, defaultRoute=None, _netinfo=None, Line 55: configurator=None, blockingdhcp=None, Line 56: implicitBonding=None, **opts): Line 57: """ -- To view, visit http://gerrit.ovirt.org/22720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b2ff711155eb0bd79ab84e979eb82c846362374 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
