Nir Soffer has posted comments on this change.
Change subject: downloadFromStream
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm/BindingXMLRPC.py
Line 152: contentLength = self.headers.\
Line 153: getheader('content-length')
Line 154:
Line 155: if contentLength is None:
Line 156: self.send_response(411)
These are not error codes but status code:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
Therefore the _ERROR suffix is not correct, and even an error :-)
Line 157: self.finish()
Line 158: return
Line 159:
Line 160: methodArgs = {'method': 'stream',
--
To view, visit http://gerrit.ovirt.org/23131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85bc63365273adf306c73ef1de7fea578ec42662
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
