Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Adding guest agent API versioning support ......................................................................
Patch Set 3: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py File vdsm/guestIF.py: Line 135: try: Line 136: return int(version) Line 137: except ValueError: Line 138: self.log.error("Received invalid version value: %s", version) Line 139: return 0 > If an invalid version should be treated like a missing version, maybe this 0 is supposed to be the lowest possible version, reporting the apiVersion at all shows it knows about this. Therefore the most possible version in that case can be only 0. -1 on the other hand means that it is disabled completely which of course can be triggered again, however this will result in some ping pong I try to avoid. Line 140: Line 141: def _setAPIVersion(self, version): Line 142: version = self._validateAPIVersion(version) Line 143: if version > _MAX_SUPPORTED_API_VERSION: -- To view, visit http://gerrit.ovirt.org/17004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
