Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: specify sysV commands for EL6 only ......................................................................
Patch Set 2: Code-Review-1 (1 comment) with_systemd is already defined. Please use it instead of cluttering the spec with references to the el version in which we need to keep sysv. http://gerrit.ovirt.org/#/c/23235/2/vdsm.spec.in File vdsm.spec.in: Line 696: fi Line 697: /sbin/restorecon -R /var/log/core >/dev/null 2>&1 Line 698: # hack until we replace core dump with abrt Line 699: Line 700: %if 0%{?rhel} == 6 it might require more work, this branch of the conditional should simply be the "%else" of the %if 0%{?with_systemd}. Line 701: if [ "$1" -eq 1 ] ; then Line 702: /sbin/chkconfig --add vdsmd Line 703: /sbin/chkconfig --add supervdsmd Line 704: fi -- To view, visit http://gerrit.ovirt.org/23235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie52ae97d48d795d53529152b68380fbd13d7927d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
