Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Determine bootproto also without ifcfg files ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23098/3/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 452: for net, info in networks.iteritems(): Line 453: ifaces[info['iface']] = net Line 454: Line 455: for pid in pgrep('dhclient', 'dhcpcd'): Line 456: args = getCmdArgs(pid) > Doesn't the fact that this opens a proc file imply a race when the process It seems so - if the process is gone, pidStat() won't even be able to open /proc/{pid}/stat to decide if it is a zombie. Line 457: Line 458: dhclient = args[0].endswith('dhclient') # I suppose there is a full path possible Line 459: dhcp4, dhcp6 = True, not dhclient # Defaults Line 460: implicit = True -- To view, visit http://gerrit.ovirt.org/23098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
