Adam Litke has posted comments on this change. Change subject: schema: Updates based on the current code base ......................................................................
Patch Set 4: Code-Review-1 (7 comments) Coming along but still some improvements needed. http://gerrit.ovirt.org/#/c/23125/4//COMMIT_MSG Commit Message: Line 11: - getAllVmStats was only available for xml so it was moved to API Line 12: - vm snapshot method had not optional argument Line 13: - added implementation for full vm list Line 14: - added gerHardwareInfo method missing from schema Line 15: - VmDeviceType type update Please split the VmDeviceType changes out as they are going to require more explanation and discussion. Line 16: Line 17: Gluster related Line 18: - Added GlusterVolume.status command and corresponding type which was Line 19: missing is schema http://gerrit.ovirt.org/#/c/23125/4/vdsm/gluster/vdsmapi-gluster-schema.json File vdsm/gluster/vdsmapi-gluster-schema.json: Line 566: # Line 567: # @DETAIL: Line 568: # Line 569: # @CLIENTS: Line 570: # Oops. trailing whitespace here. Also remember to document the meaning of each value as is done for other enums. Line 571: # @MEM: Line 572: # Line 573: # Since: 4.10.3 Line 574: ## http://gerrit.ovirt.org/#/c/23125/4/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 1042: Line 1043: ## Line 1044: # @BlockDeviceType: Line 1045: # Line 1046: # Enumeration of possible block device types represented as int. Are you sure that engine is sending over integers? If so, I would simply restore the XXX comment in this schema since we will need to apply fixes to Bridge.py until ovirt-engine can be fixed. Enums values should always be sent as string values. Line 1047: # Line 1048: # @iSCSI: The device is pure iSCSI Line 1049: # Line 1050: # @FCP: The device is purely FibreChannel Line 1668: Line 1669: ## Line 1670: # @StorageDomainImageClass: Line 1671: # Line 1672: # An enumeration of Storage Domain classes represented as int. See above comment and apply here too. Line 1673: # Line 1674: # @Unknown: The class is not known Line 1675: # @Data: The Storage Domain is used for virtual machine disk images Line 1676: # @Iso: The Storage Domain is used for storing ISO images Line 1847: # @smartcard: A smartcard device Line 1848: # Line 1849: # @rng: A rng device Line 1850: # Line 1851: # Since: 4.15 That's not a valid version. but it doesn't matter because this will be split into a different patch :) Line 1852: ## Line 1853: {'typemap': 'VmDeviceType', Line 1854: 'data': {'disk': 'VmDiskDevice', Line 1855: 'interface': 'VmInterfaceDevice', Line 2970: 'data': {'*vmList': ['UUID']}, Line 2971: 'returns': ['UUID']} Line 2972: Line 2973: ## Line 2974: # @VMFullInfo: Great. Line 2975: # Line 2976: # Full information about VM. Line 2977: # Line 2978: # @acpiEnable: Indicates if ACPI is enabled inside the VM Line 3045: # @status: State of the VM Line 3046: # Line 3047: # @clientIp: The IP address of the client connected to the display Line 3048: # Line 3049: # Since: 4.15.0 I think you'll want 4.14.1 but danken would know for sure. Line 3050: ## Line 3051: {'type': 'VMFullInfo', Line 3052: 'data': {'acpiEnable': 'bool', 'custom': 'StringMap', 'devices': ['VmDevice'], Line 3053: 'display': 'VmDisplayType', 'kvmEnable': 'bool', 'memSize': 'uint', -- To view, visit http://gerrit.ovirt.org/23125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3d0d894cc31395510733a33f4f6e15276615a3a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
