Jiří Moskovčák has posted comments on this change. Change subject: dump the core of a VM ......................................................................
Patch Set 16: Code-Review-1 (1 comment) Just a minor thing, but I'd rather see it fixed, so it won't hit as later. The rest looks ok. http://gerrit.ovirt.org/#/c/7329/16/vdsm/vm.py File vdsm/vm.py: Line 494: self.status = {'code': CoreDumpThread.Status.CANCELED, Line 495: 'message': 'The operation has been aborted'} Line 496: else: Line 497: self.status = reportError(msg=e.message) Line 498: except Exception, e: please use "<ExceptionType> as e" everywhere Line 499: self.status = reportError(msg=e.message) Line 500: Line 501: Line 502: class VolumeError(RuntimeError): -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
