Yaniv Bronhaim has posted comments on this change. Change subject: Avoid spec error outputs during installing VDSM ......................................................................
Patch Set 1: it doesn't matter. this patch is here to swallow any exceptions that can be raised during the install. afaiu its common to swallow script's errors in spec file to not interrupt the install process. the fix for this specific exception relates to http://gerrit.ovirt.org/#/c/23456 . I don't mind not to swallow every vdsm-tool stderr prints, but that's how we did it till now... -- To view, visit http://gerrit.ovirt.org/23454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b88efcf4bea3a841c1ff9795af90cf75df44b7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
