Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: fix pool membership check in attachSD
......................................................................
sp: fix pool membership check in attachSD
A race between attachStorageDomain and connectStoragePool using
StoragePoolMemoryBackend could lead to the new domain not being
attached (on storage).
The race happens in StoragePool.attachSD:
domains = self.getDomains()
if sdUUID in domains:
return True
if the domain map has been already updated by connectStoragePool
the domain is deemed attached and the remaining operations are
skipped.
In this patch:
- use only validateAttachedDomain in detachSD (validatePoolSD is
redundant)
- make attachSD symmetric to detachSD using validateAttachedDomain
to check if the domain is already attached
Change-Id: I4169ddcb4da29c8b806b5788080c16349b642197
Signed-off-by: Federico Simoncelli <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/23446
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/storage/sp.py
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Federico Simoncelli: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23446
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4169ddcb4da29c8b806b5788080c16349b642197
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
