Alon Bar-Lev has posted comments on this change. Change subject: sysvinit: Ensure that iscsid is started ......................................................................
Patch Set 1: (1 comment) no need to change upstart or systemd? what component at which stage is this special configuration for iscsid? http://gerrit.ovirt.org/#/c/23601/1/init/sysvinit/vdsmd.init.in File init/sysvinit/vdsmd.init.in: Line 86: service "${srv}" force-start Line 87: else Line 88: service "${srv}" start Line 89: fi Line 90: fi please remove the iscsid from needed_services and have specific code for it instead of touching the generic logic. Line 91: fi Line 92: ret_val=$? Line 93: if [ "${ret_val}" -ne 0 ]; then Line 94: log_failure_msg "${prog}: Start dependent ${srv}" -- To view, visit http://gerrit.ovirt.org/23601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb5c3de4f8dccb1d8344182d5016feabcf86a7df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
