Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23636
to review the following change.
Change subject: caps: report malfunctioning libvirt
......................................................................
caps: report malfunctioning libvirt
the fix applied in commit 6c6da596336d6cc1ff121057877ac6ab1f00f147
can be a source of confusion for users which expect
a Fedora 19 node is able to join a 3.4 cluster.
This patch adds log messages which briefly explain
the reason of the incompatibility and suggest a fix.
Bug-Url: https://bugzilla.redhat.com/1056918
Change-Id: I9fd62ecaabc30ccd2c5d8b8cc441de6a44b8e670
Signed-off-by: Francesco Romani <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/23628
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M vdsm/caps.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/23636/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index cdab961..b260d29 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -399,6 +399,11 @@
if hasattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR'):
return dsaversion.version_info
+ logging.error('VIR_MIGRATE_ABORT_ON_ERROR not found in libvirt,'
+ ' support for clusterLevel >= 3.4 is disabled.'
+ ' For Fedora 19 users, please consider upgrading'
+ ' libvirt from the virt-preview repository')
+
from distutils.version import StrictVersion
# Workaround: we drop the cluster 3.4+
# compatibility when we run on top of
--
To view, visit http://gerrit.ovirt.org/23636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd62ecaabc30ccd2c5d8b8cc441de6a44b8e670
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
