Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format ......................................................................
Patch Set 2: Code-Review-1 (1 comment) > py26 related? more of a naive rebase, and posting before testing. http://gerrit.ovirt.org/#/c/23660/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1463: networks = {NETWORK_NAME: {'nic': nic, 'bridged': False, Line 1464: 'bootproto': 'none'}} Line 1465: with self.vdsm_net.pinger(): Line 1466: self.vdsm_net.setupNetworks(networks, {}, {}) Line 1467: self.assertNetworkExists(NETWORK_NAME, bridged=True) rebase needs more work. Line 1468: Line 1469: self.assertTrue(os.path.isfile(hook_cookiefile)) Line 1470: Line 1471: delete_networks = {NETWORK_NAME: {'remove': True}} -- To view, visit http://gerrit.ovirt.org/23660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
