Dan Kenigsberg has submitted this change and it was merged. Change subject: Deprecate volume mtime ......................................................................
Deprecate volume mtime In pre-historic 2.y days, Engine used volume's "mtime" attribute to deduces the ancestry of a volume. See for example BZ#513396. In case of an error reading the metadata, "0" or "" was returned. This was a bad heuristic that was fixed to using proper pointer to parents and children. Engine 3.y continues to use the mtime field only when importing ancient images that lack proper creation time in their OVF. Maintaining this attribure requires costly readings of volume metadata. This patch drops the mtime-related code. For backward compatibility with old Vdsms and Engines that may expect the existance of this attribute, we keep writing "0" to the metadata and reporting "0" to Engine. Change-Id: I38b0a636222fa74125d25f0c3c9ea5b3e5701565 Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: http://gerrit.ovirt.org/20504 Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/volume.py M vdsm_api/vdsmapi-schema.json 4 files changed, 4 insertions(+), 30 deletions(-) Approvals: Federico Simoncelli: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/20504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b0a636222fa74125d25f0c3c9ea5b3e5701565 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Gadi Ickowicz <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
