Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: vdsm should own vdsm.log ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23696/2/vdsm.spec.in File vdsm.spec.in: Line 11: %global snlk_user @SNLKUSER@ Line 12: Line 13: # VDSM Log Line 14: %global logdir %{_localstatedir}/log/%{vdsm_name} Line 15: %global vdsm_log %{_localstatedir}/log/%{vdsm_name}/%{vdsm_name}.log I'm not sure that the %vdsm_log macro is helpful, as I do not see us ever moving the log file. However, @VDSMLOGDIR@ is already defined, and referring to to it does make sense. Line 16: Line 17: # Fedora official build Line 18: %global fedora_koji_build 0 Line 19: -- To view, visit http://gerrit.ovirt.org/23696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id12a78f3243138cd95a13cc7c8a8d3d499ceee4a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
