Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: replace if ! 0%{?with_systemd}
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/23603/1/vdsm.spec.in
File vdsm.spec.in:
Line 35:
Line 36: %if 0%{?fedora} >= 15 || 0%{?rhel} >= 7
Line 37: %global with_systemd 1
Line 38: %else
Line 39: %global with_sysv 1
The newly-added macro is not a good idea, as it is not independent of
%with_systemd. Having both may suggest that it's possible to set both to 1 or
both to 0 (and it doesn't).
I do not mind declaring with_systemd=1 as the default, and REPLACING it with
with_sysv.
Line 40: %endif
Line 41:
Line 42: %if 0%{?fedora} >= 18
Line 43: %global with_systemd_macros 1
--
To view, visit http://gerrit.ovirt.org/23603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a104a7ec6ed7ea57803157e9d62334a26caf7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
