Dan Kenigsberg has posted comments on this change.

Change subject: utils: Moved pgrep and getCmdArgs from storage/misc
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/23040/4//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-01-24 19:16:41 +0100
Line 6: 
Line 7: utils: Moved pgrep and getCmdArgs from storage/misc
Line 8: 
Line 9: They will be used in netinfo.py to find a running DHCP client
the move of code is still good, but the commit message is no longer true.
Line 10: and to read e.g. an interface name from its cmdline.
Line 11: 
Line 12: Change-Id: Ia9a933bec0df3f7773c0f8e47fc0bf0492149031
Line 13: Bug-Url: https://bugzilla.redhat.com/987813


-- 
To view, visit http://gerrit.ovirt.org/23040
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9a933bec0df3f7773c0f8e47fc0bf0492149031
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: OndÅ™ej Svoboda <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to