Yaniv Bronhaim has submitted this change and it was merged. Change subject: ifcfg: exclude HWADDR lines if requested ......................................................................
ifcfg: exclude HWADDR lines if requested In prehistoric days, our ifcfg files included HWADDR lines for persistent NIC names on EL5 hosts. Our currently-supported systems no longer require HWADDR for that, but rather use udev rules. HWADDRs are still required if NetworkManager is running and needs them to adhere to our NM_CONTROLLED=no directive. HWADDR lines in ifcfg files are frowned upon, since they essentially duplicate information that already exists in udev rules. Users who would like to avoid them can now configure hwaddr_in_ifcfg to "never" instead of the default "always". Bug-Url: https://bugzilla.redhat.com/1044060 Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: http://gerrit.ovirt.org/22288 Reviewed-by: Assaf Muller <[email protected]> Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-on: http://gerrit.ovirt.org/23662 Reviewed-by: Yaniv Bronhaim <[email protected]> --- M lib/vdsm/config.py.in M vdsm/netconf/ifcfg.py 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/23662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
