Dan Kenigsberg has submitted this change and it was merged. Change subject: cleanup: move _updateTimestamp to API.py ......................................................................
cleanup: move _updateTimestamp to API.py After Engine issues a setupNetworks or editNetwork API calls, it follows by repeated ping() calls. If networking has been configured correctly, the ping() is processed by Vdsm, and _updateTimestamp notifies helper tools that the network configuration should not be rolled back. This patch extends this behavior to all users of the API, not only XMLRPC. Engines of versions before 3.1 used to call getVdsCaps() instead of the lightweight ping() (Engine commit 47c61adeb133d95b has changed that). Even older Engines (before commit d87de762dbce2ba7) and modern Engines in editNetwork flows, do nothing special and depend on their periodic list() call. For backward compatibility, we add _updateTimestamp on these specific verbs, too. Change-Id: I4270df333ff5ff56e4375742cdc526ec76ed3bf1 Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: http://gerrit.ovirt.org/23050 Reviewed-by: Assaf Muller <[email protected]> Reviewed-by: Moti Asayag <[email protected]> --- M vdsm/API.py M vdsm/BindingXMLRPC.py 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4270df333ff5ff56e4375742cdc526ec76ed3bf1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
