Sandro Bonazzola has posted comments on this change. Change subject: sos: plugin should ignore /var/run/vdsm/storage ......................................................................
Patch Set 2: (1 comment) please, remember that this sos plugin doesn't work on Fedora 20 due to API change in sos-3 http://gerrit.ovirt.org/#/c/23925/2/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 120: import glob Line 121: Line 122: for f in glob.glob("@VDSMRUNDIR@/*"): Line 123: if not f.endswith('.vfd') and not f.endswith('/isoUploader') \ Line 124: and not f.endswith('/storage'): isn't it better to fix glob regexp for just take what you need? -- To view, visit http://gerrit.ovirt.org/23925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie60d681cc744f2407a0ddf9406225e73497ac648 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
