Yaniv Bronhaim has posted comments on this change. Change subject: vm.py: Always use 'qemu' domain type in fake mode ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23938/3/tests/vmTests.py File tests/vmTests.py: Line 85: finally: Line 86: shutil.rmtree(constants.P_VDSM_RUN) Line 87: constants.P_VDSM_RUN = oldVdsmRun Line 88: Line 89: @MonkeyPatch(config.config, 'getboolean', lambda s, k: False) why don't you monkey patch _hasKvm ? Line 90: def testDomXML(self): Line 91: expectedXML = """ Line 92: <domain type="kvm"> Line 93: <name>testVm</name> -- To view, visit http://gerrit.ovirt.org/23938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I875854ccc4d884aa36a77cd062521889622e567d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
