Yaniv Bronhaim has uploaded a new change for review. Change subject: Report sanlock not configured when sanlock is down ......................................................................
Report sanlock not configured when sanlock is down If sanlock is down we cannot assume that sanlock process is already related to the supplementary group. Configure verb won't configure sanlock if isconfigure return True. Therefore, this patch change the return to False so 'vdsm-tool configure' will perform the usermod action. Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057225 Signed-off-by: Yaniv Bronhaim <[email protected]> --- M lib/vdsm/tool/configurator.py 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/24007/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index dfc4115..fc893ea 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -163,7 +163,13 @@ except IOError as e: if e.errno == os.errno.ENOENT: sys.stdout.write("sanlock service is not running\n") - configured = True + # if sanlock service is not running we cannot check if + # sanlock process is related to the desired + # supplementary groups. + # Therefore, we return False to run the sanlock configure which + # performs the usermod action. Running it even if configured + # already won't harm, but not running it will. + configured = False else: raise -- To view, visit http://gerrit.ovirt.org/24007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
