Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: implement recommended clock settings
......................................................................
vm: implement recommended clock settings
A new set of recommended clock settings emerged as follows:
<clock ...>
<timer name="rtc" tickpolicy="catchup"/>
<timer name="pit" tickpolicy="delay"/>
<timer name="hpet" present="no"/>
</clock>
THose settings are recommended by both libvirt and qemu developers,
and they apply for all guest OSes.
Some of them don't affect some OSes, but in those cases they are harmless.
VDSM used to support just the first setting, tickpolicy 'catchup'
for rtc, conditioned by the presence of the 'tdf' option.
Now this setting is always enabled.
This patch updates the XML generation according with
the new recommendations, and drop all the references
to the 'tdf' variable.
API deprecation notice:
the 'tdf' parameter is no longer honored;
however, no supported engines seems to send it anymore.
Change-Id: Icb0752e54a4cb9ff609b8ddfaf5c8fe2ed5b9e72
Bug-Url: https://bugzilla.redhat.com/1053846
Signed-off-by: Francesco Romani <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/23663
Reviewed-by: Martin Polednik <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M client/vdsClient.py
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/vm.py
4 files changed, 11 insertions(+), 6 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb0752e54a4cb9ff609b8ddfaf5c8fe2ed5b9e72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
