Hello Sandro Bonazzola, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24153
to review the following change.
Change subject: Adding configure sanlock on force
......................................................................
Adding configure sanlock on force
If sanlock is down we cannot check sanlock process, so isconfigure return that
sanlock process is already related to the supplementary group.
Configure verb won't configure sanlock if isconfigure return True currently.
Therefore, this patch change the ConfigureOnForce to True so
'vdsm-tool configure --force' will perform the usermod action as the
user expected.
Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057225
Signed-off-by: Yaniv Bronhaim <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/24007
Reviewed-by: Sandro Bonazzola <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/vdsm/tool/configurator.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/24153/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index dfc4115..29172e4 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -175,7 +175,10 @@
return configured
def reconfigureOnForce(self):
- return False
+ # If sanlock is down isconfigure returns True and configure will skip
+ # sanlock configure. on force users expected to run configure even if
+ # isconfigure returned True.
+ return True
__configurers = (
--
To view, visit http://gerrit.ovirt.org/24153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb3125e64cf02e55738f5978fd81d605dd84d38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
