Vinzenz Feenstra has posted comments on this change. Change subject: execCmd: no need to pass the default sudo=False value ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24145/1//COMMIT_MSG Commit Message: Line 8: Line 9: These are remnants from the days where we had a crazier default. Line 10: Cleaned with Line 11: sed -i 's/execCmd\(.*\), sudo=False/execCmd\1/' Line 12: and a couple of manual additions. > yes, i saw the omit of sudo=False in execCmd which caught my eye. just put That must have been an accident ;) Line 13: Line 14: Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44 -- To view, visit http://gerrit.ovirt.org/24145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8c0e30756113ddb35d2e51984c3ea72bbe45a44 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
