Greg Padgett has posted comments on this change. Change subject: API: setHaMaintenanceMode command ......................................................................
Patch Set 5: (1 comment) Adam, thanks for the review. See response inline. http://gerrit.ovirt.org/#/c/23264/5/vdsm_api/vdsmapi-schema.json File vdsm_api/vdsmapi-schema.json: Line 486: # Since: 4.14.0 Line 487: ## Line 488: {'command': {'class': 'Host', 'name': 'setHaMaintenanceMode'}, Line 489: 'data': {'mode': 'HaMaintenanceMode', 'enabled': 'bool'}} Line 490: > Does this mean a host can be in both global and local maintenance modes at Yes, local and global maintenance are independent, and zero, one, or both can be enabled. Line 491: ## Line 492: # @TaskDetails: Line 493: # Line 494: # A collection of information about a task. -- To view, visit http://gerrit.ovirt.org/23264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
