Michal Skrivanek has posted comments on this change. Change subject: vm: ensure finish recover with libvirt connection ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24423/3/vdsm/vm.py File vdsm/vm.py: Line 2306: Line 2307: self.recovering = False Line 2308: self.saveState() Line 2309: except Exception as e: Line 2310: if self.recovering: > Is this check correct? seems to contradict your new code. there is quite some troublesome history with the whole recovery code. I'd suggest to go through all historical changes and verify we're not re-introducing a problem. It seems to me it's fine, but I'd be extra cautious. We've seen libvirt connections stuck on recovery, partial information, etc... Line 2311: self.log.info("Skipping errors on recovery", exc_info=True) Line 2312: else: Line 2313: self.log.error("The vm start process failed", exc_info=True) Line 2314: self.setDownStatus(ERROR, str(e)) -- To view, visit http://gerrit.ovirt.org/24423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
