Dan Kenigsberg has posted comments on this change. Change subject: introducing capability to stream data to image ......................................................................
Patch Set 12: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/23281/12/vdsm/storage/imageSharing.py File vdsm/storage/imageSharing.py: Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: import logging Line 21: import curlImgWrap Liron, I do not quite get why you keep the curlImgWrap with the stdlib imports, and not with the vdsm imports, as it should. It's not a big deal, it's just following standard, to help reviewers and make future rebases easier. Line 22: import signal Line 23: import socket Line 24: Line 25: from vdsm import constants -- To view, visit http://gerrit.ovirt.org/23281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
