Dan Kenigsberg has submitted this change and it was merged. Change subject: net_scale: avoid netinfo instantiation for removal check ......................................................................
net_scale: avoid netinfo instantiation for removal check When removing networks, delNetwork used to generate a whole NetInfo instance, which is rather costly and in the case that there's a lot of delNetworks queued up (like in a lengthy setupNetworks operation) it can impact performance significantly. We should rely on: - configurator.removeLibvirtNetwork - configurator removal methods Bug-Url: https://bugzilla.redhat.com/1053114 Change-Id: I1ff62dcd750ece1c3685c102723820aac5b432b2 Signed-off-by: Antoni S. Puimedon <[email protected]> Reviewed-on: http://gerrit.ovirt.org/24158 Reviewed-by: Douglas Schilling Landgraf <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/configNetwork.py 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ff62dcd750ece1c3685c102723820aac5b432b2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
