Nir Soffer has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24636/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 327: 'file': {'filename': 'content', ...}} Line 328: """ Line 329: if 'file' not in payload: Line 330: raise vm.VolumeError("Missing 'file' attribute in 'payload'") Line 331: Lets add this change in a new patch, so this change remain a refactoring. Line 332: mkFsNames = {'cdrom': 'mkIsoFs', 'floppy': 'mkFloppyFs'} Line 333: if device not in mkFsNames: Line 334: raise vm.VolumeError("Unsupported 'device': %s" % device) Line 335: -- To view, visit http://gerrit.ovirt.org/24636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
