Ayal Baron has posted comments on this change. Change subject: [WIP] Create storage pool using command type 1 ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 529: # to belong to the metadata volume. Since the metadata is at Line 530: # least SDMETADATA/METASIZE units, we know we can use the first Line 531: # SDMETADATA bytes of the metadata volume for the SD metadata. Line 532: # pass metadata's dev to ensure it is the first mapping Line 533: #mapping = cls.getMetaDataMapping(vgName) in final version comment needs to move with code and this needs to disappear Line 534: Line 535: # Create the rest of the BlockSD internal volumes Line 536: lvm.createLV(vgName, sd.LEASES, sd.LEASES_SIZE, safe=False) Line 537: lvm.createLV(vgName, sd.IDS, sd.IDS_SIZE, safe=False) Line 572: # no one reads it from here anyway Line 573: initialMetadata = { Line 574: sd.DMDK_VERSION: version, Line 575: sd.DMDK_SDUUID: sdUUID, Line 576: sd.DMDK_TYPE: sd.storageType(storageType), this looks like a change in semantics that shouldn't be here or in the least deserves an explanation? Line 577: sd.DMDK_CLASS: sd.class2name(domClass), Line 578: sd.DMDK_DESCRIPTION: domainName, Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN, Line 580: sd.DMDK_POOLS: '', Line 573: initialMetadata = { Line 574: sd.DMDK_VERSION: version, Line 575: sd.DMDK_SDUUID: sdUUID, Line 576: sd.DMDK_TYPE: sd.storageType(storageType), Line 577: sd.DMDK_CLASS: sd.class2name(domClass), same Line 578: sd.DMDK_DESCRIPTION: domainName, Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN, Line 580: sd.DMDK_POOLS: '', Line 581: sd.DMDK_LOCK_POLICY: '', Line 576: sd.DMDK_TYPE: sd.storageType(storageType), Line 577: sd.DMDK_CLASS: sd.class2name(domClass), Line 578: sd.DMDK_DESCRIPTION: domainName, Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN, Line 580: sd.DMDK_POOLS: '', ? Line 581: sd.DMDK_LOCK_POLICY: '', Line 582: sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC: sd.DEFAULT_LEASE_PARAMS[ Line 583: sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC], Line 584: sd.DMDK_LEASE_TIME_SEC: sd.DEFAULT_LEASE_PARAMS[ Line 593: } Line 594: Line 595: initialMetadata.update(mapping) Line 596: toAdd = encodeVgTags(initialMetadata) Line 597: lvm.changeVGTags(vgName, delTags=(), addTags=toAdd, safe=False) if it is not safe/possible to call md.update then need to explain this Line 598: Line 599: # Mark VG with Storage Domain Tag Line 600: try: Line 601: lvm.replaceVGTag(vgName, STORAGE_UNREADY_DOMAIN_TAG, -- To view, visit http://gerrit.ovirt.org/23647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
