Dan Kenigsberg has posted comments on this change. Change subject: net_scale: Don't instantiate NetInfo needlessly ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/23576/7/vdsm/configNetwork.py File vdsm/configNetwork.py: Line 461: nics = bondingAttrs.get('nics', None) Line 462: if not nics: Line 463: raise ConfigNetworkError(ne.ERR_BAD_PARAMS, Line 464: "Must specify nics for bonding") Line 465: if not set(nics).issubset(set(currentNics)): sorry for being pedantic, but the set() should be calculated once as well. Line 466: raise ConfigNetworkError(ne.ERR_BAD_NIC, Line 467: "Unknown nics in: %r" % list(nics)) Line 468: Line 469: -- To view, visit http://gerrit.ovirt.org/23576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
