Alon Bar-Lev has posted comments on this change. Change subject: Adding remove\disable verbs to vdsm-tool for admin usages ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/21772/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 29: from ..constants import P_VDSM_EXEC, DISKIMAGE_GROUP, QEMU_PROCESS_GROUP, \ Line 30: VDSM_GROUP, P_VDSM_LCONF, P_VDSM_QCONF, P_VDSM_LDCONF, P_SYSTEMCTL_CONF Line 31: Line 32: Line 33: def removeSectionFromFile(filename, beginField=None, endField=None): > yes.... I remember that, but after seeing below .. i asked for opinions ab I do not think it is that complex, and it can be improved (testing the exact lines we add instead of signature before/after). I would much like to see that shell script go away. Line 34: ( Line 35: BEFORE, Line 36: WITHIN, Line 37: AFTER, -- To view, visit http://gerrit.ovirt.org/21772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
