Francesco Romani has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py File vdsm/vm.py: Line 4582: elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT: Line 4583: self.log.info('I/O error %s device %s reported to guest OS', Line 4584: err, blockDevAlias) Line 4585: else: Line 4586: self.log.info('I/O error %s device %s action %i ignored', > just a nit, this should probably be an error since the current libvirt list I think you are right. Will change. Line 4587: err, blockDevAlias, action) Line 4588: Line 4589: def _acpiShutdown(self): Line 4590: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN) -- To view, visit http://gerrit.ovirt.org/25157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
