Ondřej Svoboda has posted comments on this change. Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25170/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1660: veth.setIP(left, IP_ADDRESS, IP_CIDR) Line 1661: veth.setLinkUp(left) Line 1662: with dnsmasqDhcp(left): Line 1663: network = {NETWORK_NAME: {'nic': right, 'bridged': False, Line 1664: 'bootproto': 'dhcp'}} > oh dear. this explains a lot - in particular, why slaves lost their connect It is already there, in dhcp.py :-/ Line 1665: Line 1666: status, msg = self.vdsm_net.setupNetworks(network, {}, NOCHK) Line 1667: self.assertEqual(status, SUCCESS, msg) Line 1668: self.assertNetworkExists(NETWORK_NAME) Line 1667: self.assertEqual(status, SUCCESS, msg) Line 1668: self.assertNetworkExists(NETWORK_NAME) Line 1669: Line 1670: net = self.vdsm_net.netinfo.networks[NETWORK_NAME] Line 1671: self.assertEqual(net['bootproto4'], 'dhcp') > please add an asserion for the legacy ['cfg'][BOOTPROTO] report. Along with 'bridged': True, added (I had it here prepared). Line 1672: Line 1673: network = {NETWORK_NAME: {'remove': True}} Line 1674: status, msg = self.vdsm_net.setupNetworks(network, {}, NOCHK) Line 1675: self.assertEqual(status, SUCCESS, msg) -- To view, visit http://gerrit.ovirt.org/25170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
