Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: Fix wrong filtering of dummy devices ......................................................................
netinfo: Fix wrong filtering of dummy devices Dummy (and veth) devices were being filtered for use by vdsm in the method isFakeNic, but in the method that is used to determine what is reported as nics, isNicLike, it was not being used, and instead isDUMMY and isVETH were being called. Before this patch, any veth and dummy device were reported in the nics() method of netinfo. After this patch only those that match the explicit fake setting will be reported. Change-Id: I3809eb1bb3230543bd586dcf722e2603da16952a Signed-off-by: Antoni S. Puimedon <[email protected]> Reviewed-on: http://gerrit.ovirt.org/24175 Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/ipwrapper.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3809eb1bb3230543bd586dcf722e2603da16952a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
