Douglas Schilling Landgraf has posted comments on this change. Change subject: sos: Support SOS version 3 ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25188/2/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Line 21: try: Line 22: from sos.plugins import Plugin, RedHatPlugin > adding a silly When I created the patch, I was worried to not created a second plugin for v3 and easy way to maintain so autoconf to me appeared as glove. Anyway, I will try your suggestion.Thanks Line 23: except ImportError: Line 24: import sos.plugintools Line 25: Line 26: import subprocess -- To view, visit http://gerrit.ovirt.org/25188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52fbd9431506c5862cc762b4d3f0701ab5cf6a0b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
