Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Add shorthand NetInfo.bridges for consistency ......................................................................
Patch Set 1: (1 comment) How minimal can the 'bridges' dictionary be? I don't think the information must be full-blown in a mere test. 'nics' dictinary degraded into a simple iterable; I propose tu put 'ports' in the dictionary because there is no more information contained in 'networks' for the bridges. http://gerrit.ovirt.org/#/c/25212/1/tests/configNetworkTests.py File tests/configNetworkTests.py: Line 87: } Line 88: }, Line 89: 'nics': ['eth0', 'eth1', 'eth2', 'eth3', 'eth4', 'eth5', 'eth6', Line 90: 'eth7', 'eth8', 'eth9', 'eth10'], Line 91: 'bridges': {}, > This is not consistent with the rest of the information in _netinfo. fakebr Is e.g. 'fakebrnet2': {'ports': ['eth7.1']} enough for a bridge record? Line 92: 'bondings': {'bond00': {'slaves': ['eth5', 'eth6']}} Line 93: } Line 94: Line 95: fakeInfo = netinfo.NetInfo(_netinfo) -- To view, visit http://gerrit.ovirt.org/25212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf14be0a4db0678b4653512accd48b5ee9a43e1d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
